Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve machine-generated linter rules JSON file #4587

Closed
parlough opened this issue Jul 20, 2023 · 3 comments · Fixed by #4590
Closed

Preserve machine-generated linter rules JSON file #4587

parlough opened this issue Jul 20, 2023 · 3 comments · Fixed by #4590
Assignees
Labels
P2 A bug or feature request we're likely to work on type-task

Comments

@parlough
Copy link
Member

The machine-generated rules.json file found on the gh-pages branch at https://github.com/dart-lang/linter/blob/gh-pages/lints/machine/rules.json is still used by a few clients.

For the purposes of moving to the SDK, it should potentially be checked in to the main branch with a test to make sure it's up to date.

\cc @pq

@pq pq self-assigned this Jul 20, 2023
@pq pq added P2 A bug or feature request we're likely to work on type-task labels Jul 20, 2023
@pq
Copy link
Member

pq commented Jul 20, 2023

Thinking about a location... We could put it adjacent to all.yaml? (Though example/ is maybe a strange directory for it to live in.) Maybe a doc dir like server has?

@parlough: thoughts?

@parlough
Copy link
Member Author

Yeah I agree that example/ might be a bit confusing since it's not an example.

I was think the generation logic and the file itself could live in /tool/machine to keep things together but a doc directory would be fine too.

@pq
Copy link
Member

pq commented Jul 20, 2023

/tool/machine SGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants