write and verify rules.json

[pq]

Fixes #4587

@parlough: let me know if this is what you had in mind?

/cc @bwilkerson @srawlins

[coveralls]

coverage: 96.773%. remained the same when pulling 6c7bc93 on rules_json into 06c9c95 on main.

[parlough]

I'm happy with this! However it may not be what you want, since it will break if one of the lints packages modifies their list of lints or the error fix status map changes. Perhaps we want to adjust those to the latest stable tag/commit rather than main? Another benefit of that is it more closely matches what most users will experience.

Another option is adding a specific version of the lints and flutter_lints packages as dev dependencies and pulling the files from there.

[pq]

Great points!

My gut is that in practice we won't get bitten here too often. My thinking being:

1. lints and flutter_lints updates happen very infrequently, and while
2. error_fix_status.yaml might change more frequently, it will become less of a hassle when we're co-located in the same repo and can make atomic changes

I guess I'm inclined to take the "simple" approach first and rethink if it becomes a problem down the road.

How does that sound?

[parlough]

Sounds good to me :)

Thanks for working on this!

[pq]

Another benefit of that is it more closely matches what most users will experience.

Regarding this, won't the version of rules.json users generally interact w/ still be on dart.dev somewhere? And correspond to the latest stable release?

[parlough]

Regarding this, won't the version of rules.json users generally interact w/ still be on dart.dev somewhere? And correspond to the latest stable release?

It's kind of in an awkward spot for now. Since the analyzer still points to the the linter rule documentation rather than the diagnostic version for lints, I try to keep it up to date for main. That way new lints don't have a dead link for users on beta and dev. So for now I usually just manually update the fix status to match stable.

Once we switch to pointing to consistent diagnostic information, I don't think this will be a problem anymore.