Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove automatic gh-pages doc generation #4625

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Remove automatic gh-pages doc generation #4625

merged 2 commits into from
Aug 1, 2023

Conversation

parlough
Copy link
Member

@parlough parlough commented Jul 30, 2023 •
edited
Loading

  • Removes the old doc.dart tooling and moves what's still used to machine.dart
  • Removes the gh-pages workflow
  • Reduces hanging by automatically closing the http clients

@coveralls
Copy link

coveralls commented Jul 30, 2023 •
edited
Loading

Coverage Status

coverage: 96.496% (+0.02%) from 96.475% when pulling 6a94618 on parlough:feature/remove-gh-pages-doc-generation into b69163a on dart-lang:main.

@parlough parlough mentioned this pull request Jul 30, 2023
Closed
@parlough parlough marked this pull request as ready for review July 30, 2023 18:42
@parlough parlough mentioned this pull request Jul 30, 2023
Merged
pq
pq approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pq
Copy link
Member

pq commented Aug 1, 2023

Thanks @parlough!

Is this good to land?

@parlough
Copy link
Member Author

parlough commented Aug 1, 2023

Is this good to land?

Yep!

@pq pq merged commit e02fb57 into dart-lang:main Aug 1, 2023
6 checks passed
@parlough parlough deleted the feature/remove-gh-pages-doc-generation branch August 1, 2023 19:07
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@parlough
Remove automatic gh-pages doc generation (dart-lang/linter#4625)
1266444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parlough @coveralls @pq