Use curly braces in if statement, in accordance with upcoming lint rule change. #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…le change.
This lint rule currently measures from the end of the condition, but needs to measure from the start of the if-statement. E.g.
if ("long condition and other long condition" != "another long condition" &&
"more tests".isNotEmpty) return null;
This is currently allowed, but should not be, as per Effective Dart.
This will be fixed in a Dart SDK CL.
PiperOrigin-RevId: 647347218
copybara-service
bot
force-pushed
the
test_647076061
branch
from
fb10266
to
a7fdf71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use curly braces in if statement, in accordance with upcoming lint rule change.
This lint rule currently measures from the end of the condition, but needs to measure from the start of the if-statement. E.g.
if ("long condition and other long condition" != "another long condition" &&
"more tests".isNotEmpty) return null;
This is currently allowed, but should not be, as per Effective Dart.
This will be fixed in a Dart SDK CL.