-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose wasm readiness analysis in the report (without any score) #1396
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -78,6 +78,10 @@ Could not determine supported platforms as package resolution failed. | |
Run `dart pub get` for more information. | ||
</details> | ||
|
||
### [x] 0/0 points: WASM readiness | ||
|
||
Unable to detect compatibility with runtime `wasm`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need a reason here. Is it because the resolution failed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Either the resolution failed or there are error-level issues in the code, which prevent static analysis. As these are exposed at the other parts of the report, I don't think we need to repeat them here. |
||
|
||
## 0/50 Pass static analysis | ||
|
||
### [x] 0/50 points: code has no errors, warnings, lints, or formatting issues | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps: