Handle failure to retrieve status when testing advisory cache age (#4337

)
dart-lang · Aug 15, 2024 · 9de221d · 9de221d
1 parent 8ab5be0
commit 9de221d
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/lib/src/source/hosted.dart b/lib/src/source/hosted.dart
@@ -783,10 +783,14 @@ class HostedSource extends CachedSource {
           }
           final parsedCacheAdvisoriesUpdated =
               DateTime.parse(cachedAdvisoriesUpdated);
-          if ((await status(id.toRef(), id.version, cache))
-              .advisoriesUpdated!
-              .isAfter(parsedCacheAdvisoriesUpdated)) {
-            // too old
+          final advisoriesUpdated =
+              (await status(id.toRef(), id.version, cache)).advisoriesUpdated;
+
+          if (
+              // We could not obtain the timestamp of latest advisory update.
+              advisoriesUpdated == null ||
+                  // The cached entry is too old.
+                  advisoriesUpdated.isAfter(parsedCacheAdvisoriesUpdated)) {
             tryDeleteEntry(advisoriesCachePath);
           } else {
             return _extractAdvisoryDetailsForPackage(doc, id.toRef().name);