Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tar #3976

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Update tar #3976

merged 3 commits into from
Aug 7, 2023

Conversation

simolus3
Copy link
Contributor

Rolls tar to 1.0.0. The changes in that package mostly consist of adding class modifiers and a few unawaited() markers. TarFormat has been changed to distinguish between fully known formats and combinations the reader is still working out, but those aren't used by pub.

So I think pub shouldn't be affected by those changes, but as usual I've pushed a version of the extract_all_pub_dev.dart script that compares the two versions in my fork on the compare-tars branch.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@simolus3
Copy link
Contributor Author

Hm, seems like I need to do a 1.0.1 to support Dart 3.1

@simolus3
Copy link
Contributor Author

I think it's a bit unfortunate that pub has diverged from the upstream tar package in #3862. I get that it was probably urgent to fix, but it would be nice if I at least get notified when I need to make a fix in tar to support upcoming Dart versions. All tar versions blow 1.0.1 will be broken with the next stable Dart release, and I could have known this months ago...

Either way, the vendored copy is now in sync with the upstream package again and it seems to be working.

@sigurdm
Copy link
Contributor

sigurdm commented Aug 7, 2023

I get that it was probably urgent to fix, but it would be nice if I at least get notified when I need to make a fix in tar to support upcoming Dart versions.

Sorry - I think this fix was landed without noticing that the library was vendored.

@sigurdm
Copy link
Contributor

sigurdm commented Aug 7, 2023

Thanks!

@sigurdm sigurdm merged commit d764740 into dart-lang:master Aug 7, 2023
23 checks passed
@simolus3 simolus3 deleted the update-tar branch August 7, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants