Skip to content

Commit

Permalink
[element model] fix no_wildcard_variable_uses migration
Browse files Browse the repository at this point in the history
Bug: dart-lang/linter#5099

Change-Id: Ibde9394aa21fd4d81242e51cfad3f6166c1b2653
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388044
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
  • Loading branch information
pq authored and Commit Queue committed Oct 3, 2024
1 parent c514eb5 commit 7b3718c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 6 additions & 0 deletions pkg/analyzer/lib/src/dart/element/extensions.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import 'package:analyzer/dart/analysis/features.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/dart/element/element2.dart';
import 'package:analyzer/dart/element/nullability_suffix.dart';
import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/src/dart/element/element.dart';
Expand Down Expand Up @@ -161,6 +162,11 @@ extension LibraryExtension on LibraryElement? {
}
}

extension LibraryExtension2 on LibraryElement2? {
bool get hasWildcardVariablesFeatureEnabled2 =>
this?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
}

extension ParameterElementExtensions on ParameterElement {
/// Return [ParameterElement] with the specified properties replaced.
ParameterElement copyWith({
Expand Down
4 changes: 1 addition & 3 deletions pkg/linter/lib/src/rules/no_wildcard_variable_uses.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ class NoWildcardVariableUses extends LintRule {
@override
void registerNodeProcessors(
NodeLintRegistry registry, LinterContext context) {
if (context.libraryElement.hasWildcardVariablesFeatureEnabled) {
return;
}
if (context.libraryElement2.hasWildcardVariablesFeatureEnabled2) return;

var visitor = _Visitor(this);
registry.addSimpleIdentifier(this, visitor);
Expand Down

0 comments on commit 7b3718c

Please sign in to comment.