Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UTF-8 note #5471

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add UTF-8 note #5471

merged 2 commits into from
Jan 22, 2024

Conversation

atsansone
Copy link
Contributor

Fixes #5453

_config.yml Outdated Show resolved Hide resolved
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Jan 22, 2024

Visit the preview URL for this PR (updated for commit 8907359):

https://dart-dev--pr5471-fix-5453-sxitttys.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

One link needs to be readjusted:

src/tools/sdk.md Outdated Show resolved Hide resolved
@parlough parlough removed the review.copy Awaiting Copy Review label Jan 22, 2024
@parlough parlough assigned atsansone and unassigned MaryaBelanger Jan 22, 2024
@parlough parlough added the st.RFM.% Ready to Merge but has suggestions label Jan 22, 2024
Co-authored-by: Parker Lougheed <[email protected]>
@atsansone atsansone merged commit 4a8dd6c into dart-lang:main Jan 22, 2024
8 checks passed
atsansone added a commit to atsansone/site-www that referenced this pull request Jan 26, 2024
Fixes dart-lang#5453

---------

Co-authored-by: Parker Lougheed <[email protected]>
atsansone added a commit to atsansone/site-www that referenced this pull request Feb 20, 2024
Fixes dart-lang#5453

---------

Co-authored-by: Parker Lougheed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
st.RFM.% Ready to Merge but has suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that SDK tooling expects Dart files to be UTF-8 encoded
4 participants