Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial documentation for doc comment references #6080

Merged
merged 18 commits into from
Oct 10, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Sep 9, 2024

Resolves #6076

This does not discuss "doc imports"; I'd like that to be a separate addition.

Staged: https://dart-dev--pr6080-doc-comment-references-cx0x9ulm.web.app/tools/doc-comment-references

@srawlins
Copy link
Member Author

srawlins commented Sep 9, 2024

CC @dart-lang/analyzer-team for any comments.

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Sep 9, 2024

Visit the preview URL for this PR (updated for commit 3037c83):

https://dart-dev--pr6080-doc-comment-references-cx0x9ulm.web.app

@parlough parlough self-requested a review September 9, 2024 21:49
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
@srawlins
Copy link
Member Author

This is lovely that it is staged at https://dart-dev--pr6080-doc-comment-references-37rf6iwi.web.app/tools/doc-comment-references.

@srawlins
Copy link
Member Author

Ready for review.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @srawlins! It's super exciting to finally have this officially documented.

These docs look great to me and could land in the current state if you prefer, but I have a few comments, questions, and enhancements for you to consider. The main thing is that big blocks of text can be intimidating and are often skipped over, especially if someone knows something exists and just wants to know the syntax of it.

Feel free to push back on any of my comments or defer them for later (or for me).

I'll try to open a separate PR this week to explore how we can layout this page alongside other doc-comment related pages.

src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
@srawlins
Copy link
Member Author

Sorry for the delay; this is ready for review again. 😀

@parlough parlough self-requested a review October 2, 2024 21:43
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this @srawlins and the adjustments!

I have some final suggestions to consider then should be good to land. I'll work on a followup PR to add the PR to the sidenav with some other doc related entries.

src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
If the element does not have a documentation page (for example, a function
parameter, a type variable, or a private class), then no link is created.

## What can be referenced
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for exploring this! It seems a bit cramped with the table formatting, so maybe let's drop the table for now. I can revisit this with some different formats or custom styles as follow up.

src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
Copy link
Member Author

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
If the element does not have a documentation page (for example, a function
parameter, a type variable, or a private class), then no link is created.

## What can be referenced
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG. I'm sure there's a good solution in here. Maybe just experiment with different table layouts.

src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
src/content/tools/doc-comment-references.md Outdated Show resolved Hide resolved
@parlough parlough merged commit 1ac29c0 into dart-lang:main Oct 10, 2024
10 checks passed
@parlough
Copy link
Member

parlough commented Oct 10, 2024

Thanks again Sam! This is now live with a redirect to it that tools or external docs can reference: https://dart.dev/to/doc-comment-references

I hope to get time to work on some related docs soon so it has a place it live in the sidenav.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What can be referenced in a documentation comment reference?
4 participants