Add TODOs

dart-lang · Aug 22, 2023 · 2064788 · 2064788
1 parent 704c0d5
commit 2064788
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart
@@ -989,6 +989,8 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
 
   // Note: Ignore the optional local parameter, it is there to keep the method
   // signature consistent with the VM service interface.
+  // TODO(https://github.com/dart-lang/webdev/issues/2198): Add support for g3-
+  // relative URIs, and support the `local` parameter.
   @override
   Future<UriList> lookupResolvedPackageUris(
     String isolateId,

diff --git a/dwds/lib/src/utilities/dart_uri.dart b/dwds/lib/src/utilities/dart_uri.dart
@@ -140,6 +140,8 @@ class DartUri {
 
     // If this is an internal app, then the given uri might be g3-relative:
     if (globalIsInternalBuild) {
+      // TODO(https://github.com/dart-lang/webdev/issues/2198): Verify if the
+      // intermediary conversion to resolvedUri is causing performance issues.
       final resolvedUri = _g3RelativeUriToResolvedUri[uri];
       return _resolvedUriToUri[resolvedUri];
     }