Update SDK min consrraint to require new debugger runtime API

dart-lang · Jul 24, 2023 · 53dfd41 · 53dfd41
1 parent 6bcd17d
commit 53dfd41
Show file tree

Hide file tree

Showing 17 changed files with 18 additions and 19 deletions.
diff --git a/dwds/debug_extension/pubspec.yaml b/dwds/debug_extension/pubspec.yaml
@@ -6,7 +6,7 @@ description: >-
   A chrome extension for Dart debugging.
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   async: ^2.3.0

diff --git a/dwds/debug_extension_mv3/pubspec.yaml b/dwds/debug_extension_mv3/pubspec.yaml
@@ -6,7 +6,7 @@ description: >-
   A Chrome extension for Dart debugging.
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   built_value: ^8.3.0

diff --git a/dwds/lib/src/debugging/instance.dart b/dwds/lib/src/debugging/instance.dart
@@ -868,17 +868,16 @@ class InstanceHelper extends Domain {
           id: objectId,
           identityHashCode: objectId.hashCode,
           classRef: classRefForClosure,
-          // TODO(grouma) - fill this in properly.
+          // TODO(annagrin) - fill this in properly.
           closureFunction: FuncRef(
             name: functionMetaData.name,
             id: createId(),
-            // TODO(alanknight): The right ClassRef
             owner: classRefForUnknown,
             isConst: false,
             isStatic: false,
-            // TODO(annagrin): get information about getters and setters from symbols.
-            // https://github.com/dart-lang/sdk/issues/46723
             implicit: false,
+            isGetter: false,
+            isSetter: false,
           ),
           closureContext: ContextRef(length: 0, id: createId()),
         );

diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml
@@ -6,7 +6,7 @@ description: >-
   service protocol.
 repository: https://github.com/dart-lang/webdev/tree/master/dwds
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   async: ^2.9.0

diff --git a/dwds/test/chrome_proxy_service_test.dart b/dwds/test/chrome_proxy_service_test.dart
@@ -39,7 +39,6 @@ void main() {
       await context.setUp(
         enableExpressionEvaluation: true,
         verboseCompiler: false,
-        canaryFeatures: true,
       );
     });
 

diff --git a/example/pubspec.yaml b/example/pubspec.yaml
@@ -4,7 +4,7 @@ description: A web app example for webdev CLI.
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dev_dependencies:
   build_runner: ^2.4.0

diff --git a/fixtures/_test/pubspec.yaml b/fixtures/_test/pubspec.yaml
@@ -9,7 +9,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   intl: ^0.17.0

diff --git a/fixtures/_testCircular1/pubspec.yaml b/fixtures/_testCircular1/pubspec.yaml
@@ -9,7 +9,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   intl: ^0.17.0

diff --git a/fixtures/_testCircular1Sound/pubspec.yaml b/fixtures/_testCircular1Sound/pubspec.yaml
@@ -5,7 +5,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   intl: ^0.17.0

diff --git a/fixtures/_testCircular2/pubspec.yaml b/fixtures/_testCircular2/pubspec.yaml
@@ -9,7 +9,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   _test_circular1:

diff --git a/fixtures/_testCircular2Sound/pubspec.yaml b/fixtures/_testCircular2Sound/pubspec.yaml
@@ -5,7 +5,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   _test_circular1_sound:

diff --git a/fixtures/_testPackageSound/pubspec.yaml b/fixtures/_testPackageSound/pubspec.yaml
@@ -5,7 +5,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   _test_sound:

diff --git a/fixtures/_testSound/pubspec.yaml b/fixtures/_testSound/pubspec.yaml
@@ -5,7 +5,7 @@ description: >-
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   intl: ^0.17.0

diff --git a/fixtures/_webdevSmoke/pubspec.yaml b/fixtures/_webdevSmoke/pubspec.yaml
@@ -14,7 +14,7 @@ publish_to: none
 # and build_web_compilers constraint should match those defined
 # in pubspec.dart.
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dev_dependencies:
   build_runner: '>=1.6.2 <3.0.0'

diff --git a/fixtures/_webdevSoundSmoke/pubspec.yaml b/fixtures/_webdevSoundSmoke/pubspec.yaml
@@ -4,7 +4,7 @@ description: A test fixture for webdev testing with sound support.
 publish_to: none
 
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dev_dependencies:
   build_runner: ^2.4.0

diff --git a/webdev/CHANGELOG.md b/webdev/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## 3.0.7-wip
 
 - Update `build_web_compilers` constraint to `^4.0.4`.
+- Update SDK constraint to `>=3.1.0-340.0.dev <4.0.0`.
 
 ## 3.0.6
 

diff --git a/webdev/pubspec.yaml b/webdev/pubspec.yaml
@@ -8,7 +8,7 @@ description: >-
   features for users and tools to build and deploy web applications with Dart.
 repository: https://github.com/dart-lang/webdev/tree/master/webdev
 environment:
-  sdk: ">=3.1.0-254.0.dev <4.0.0"
+  sdk: ">=3.1.0-340.0.dev <4.0.0"
 
 dependencies:
   args: ^2.3.1