Updated build_web_compilers and added tests

dart-lang · Jul 7, 2023 · dce82fb · dce82fb
1 parent 53c7da0
commit dce82fb
Show file tree

Hide file tree

Showing 16 changed files with 25 additions and 18 deletions.
diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 - Require clients to specify the `basePath` on `AssetReader`. - [#2160](https://github.com/dart-lang/webdev/pull/2160)
 - Update SDK constraint to `>=3.1.0-254.0.dev <4.0.0`. - [#2169](https://github.com/dart-lang/webdev/pull/2169)
+- Require min `build_web_compilers` version `4.0.4` - [#]()
 
 ## 19.0.2
 

diff --git a/dwds/debug_extension/pubspec.yaml b/dwds/debug_extension/pubspec.yaml
@@ -18,7 +18,7 @@ dependencies:
 
 dev_dependencies:
   build: ^2.0.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
   build_runner: ^2.4.0
   built_collection: ^5.0.0
   dwds: ^11.0.0

diff --git a/dwds/debug_extension_mv3/pubspec.yaml b/dwds/debug_extension_mv3/pubspec.yaml
@@ -18,7 +18,7 @@ dev_dependencies:
   build_runner: ^2.4.0
   built_collection: ^5.0.0
   built_value_generator: ^8.3.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
   dwds: ^16.0.0
   sse: ^4.1.2
   web_socket_channel: ^2.2.0

diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml
@@ -43,7 +43,7 @@ dev_dependencies:
   build_daemon: ^4.0.0
   build_runner: ^2.4.0
   build_version: ^2.1.1
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
   built_value_generator: ^8.3.0
   dart_code_metrics: ^5.5.0
   graphs: ^2.1.0

diff --git a/dwds/test/instances/instance_canary_test.dart b/dwds/test/instances/instance_canary_test.dart
@@ -18,11 +18,13 @@ void main() {
   // Enable verbose logging for debugging.
   final debug = false;
 
-  _runAllTests(
-    canaryFeatures: true,
-    compilationMode: CompilationMode.frontendServer,
-    debug: debug,
-  );
+  for (var compilationMode in CompilationMode.values) {
+    _runAllTests(
+      canaryFeatures: true,
+      compilationMode: compilationMode,
+      debug: debug,
+    );
+  }
 }
 
 void _runAllTests({

diff --git a/dwds/test/instances/instance_test.dart b/dwds/test/instances/instance_test.dart
@@ -23,7 +23,7 @@ void main() {
   final provider = TestSdkConfigurationProvider(verbose: debug);
   tearDownAll(provider.dispose);
 
-  for (var compilationMode in [CompilationMode.frontendServer]) {
+  for (var compilationMode in CompilationMode.values) {
     _runTests(
       provider: provider,
       compilationMode: compilationMode,

diff --git a/example/pubspec.yaml b/example/pubspec.yaml
@@ -8,4 +8,4 @@ environment:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
diff --git a/fixtures/_experimentSound/pubspec.yaml b/fixtures/_experimentSound/pubspec.yaml
@@ -13,4 +13,4 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
diff --git a/fixtures/_testCircular1Sound/pubspec.yaml b/fixtures/_testCircular1Sound/pubspec.yaml
@@ -15,5 +15,5 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
 
diff --git a/fixtures/_testCircular2Sound/pubspec.yaml b/fixtures/_testCircular2Sound/pubspec.yaml
@@ -13,5 +13,5 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
 
diff --git a/fixtures/_testPackageSound/pubspec.yaml b/fixtures/_testPackageSound/pubspec.yaml
@@ -13,5 +13,5 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
 
diff --git a/fixtures/_testSound/pubspec.yaml b/fixtures/_testSound/pubspec.yaml
@@ -13,5 +13,5 @@ dependencies:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
 
diff --git a/fixtures/_webdevSoundSmoke/pubspec.yaml b/fixtures/_webdevSoundSmoke/pubspec.yaml
@@ -8,4 +8,4 @@ environment:
 
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
diff --git a/webdev/CHANGELOG.md b/webdev/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 3.0.7-wip
+
+- Update `build_web_compilers` constraint to `^4.0.4`.
+
 ## 3.0.6
 
 - Update `dwds` constraint to `19.0.2`.

diff --git a/webdev/README.md b/webdev/README.md
@@ -11,7 +11,7 @@ similar to:
 ...
 dev_dependencies:
   build_runner: ^2.4.0
-  build_web_compilers: ^4.0.0
+  build_web_compilers: ^4.0.4
 ...
 ```
 

diff --git a/webdev/lib/src/pubspec.dart b/webdev/lib/src/pubspec.dart
@@ -162,7 +162,7 @@ Future<List<PackageExceptionDetails>> _validateBuildDaemonVersion(
 }
 
 final buildRunnerConstraint = VersionConstraint.parse('^2.4.0');
-final buildWebCompilersConstraint = VersionConstraint.parse('^4.0.0');
+final buildWebCompilersConstraint = VersionConstraint.parse('^4.0.4');
 
 // Note the minimum versions should never be dev versions as users will not
 // get them by default.