Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DDC runtime debugger API #2159

Merged
merged 30 commits into from
Aug 3, 2023
Merged

Use DDC runtime debugger API #2159

merged 30 commits into from
Aug 3, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jun 23, 2023 •
edited
Loading

Use new DDC runtime debugger API that support old and new type systems.

  • Remove JS code used to collect runtime information for chrome remote objects
    • replace by corresponding DDC runtime calls
  • Add instance tests for canary mode

Closes: #2157
Closes: #2175

@annagrin annagrin marked this pull request as draft June 23, 2023 22:21
@annagrin annagrin changed the title [WIP] Use DDC debugger API [WIP] Use DDC runtime debugger API Jun 23, 2023
@annagrin annagrin mentioned this pull request Jun 23, 2023
Closed
10 tasks
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Jul 24, 2023
@annagrin annagrin marked this pull request as ready for review July 27, 2023 22:31
@annagrin annagrin changed the title [WIP] Use DDC runtime debugger API Use DDC runtime debugger API Jul 27, 2023
@annagrin annagrin requested a review from elliette July 27, 2023 22:32
@annagrin annagrin merged commit db1f552 into dart-lang:master Aug 3, 2023
47 checks passed
@annagrin annagrin mentioned this pull request Aug 8, 2023
Closed
@elliette elliette mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
dart-debug-extension package:dwds package:webdev run-dcm-workflow type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run all instance tests with ddc --canary flag Use new DDC debugger API
2 participants
@annagrin @elliette