Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid passing a nullable value to Future<nn-type>.value or Completer<nn-type>.completer. #2205

Merged
merged 1 commit into from
Sep 11, 2023

Commits on Sep 6, 2023

  1. Avoid passing a nullable value to Future<nn-type>.value or Completer<…

    …nn-type>.completer.
    
    This is cleanup work required to start enforcing this with static analysis, as per dart-lang/sdk#53253.
    
    Real quick this issue is that this code is unsafe:
    
    ```dart
    void f(Completer<int> c, int? i) {
      Future<int>.value(i); // Ouch!
      c.complete(i);        // Ouch!
    }
    ```
    
    This change should be a no-op. Adding this explicit null-assert ensures that any exception is thrown right at the null-assert.
    srawlins committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    38d938f View commit details
    Browse the repository at this point in the history