Share analysis config between packages #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
misc/shared-analysis-config
branch
from
0a39e9c
to
24772a6
Compare
parlough
force-pushed
the
misc/shared-analysis-config
branch
from
24772a6
to
6e0cdc9
Compare
bkonyi
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the various analysis option setups to a shared package that can be used as a path-based dev dependency by this repo's various packages to standardize the analysis configuration within the repo and reduce duplication. Then also fix the resulting lints :)
This will help the transition to a shared workspace with a shared analysis config in the future once each package can update its SDK constraints.