Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update daily testing to run the entire test suite" #2472

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Revert "Update daily testing to run the entire test suite" #2472

merged 1 commit into from
Aug 2, 2024

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Aug 2, 2024

Reverts #2468

@bkonyi bkonyi requested a review from elliette August 2, 2024 15:07
@bkonyi bkonyi enabled auto-merge (squash) August 2, 2024 15:07
@github-actions github-actions bot added package:webdev package:dwds type-infra A repository infrastructure change or enhancement labels Aug 2, 2024
@elliette
Copy link
Contributor

elliette commented Aug 2, 2024

Did this cause an issue?

@bkonyi bkonyi merged commit b9ca622 into main Aug 2, 2024
53 of 54 checks passed
@bkonyi bkonyi deleted the revert-2468-expand_daily_testing_coverage branch August 2, 2024 16:11
@bkonyi
Copy link
Collaborator Author

bkonyi commented Aug 2, 2024

Did this cause an issue?

Yes, see https://github.com/dart-lang/webdev/actions/runs/10216872297. I don't have time to investigate today so I figured we're better off reverting for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
changelog-not-required package:dwds package:webdev type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkonyi @elliette