config.hpp.in: remove whitespace from version macros

[scpeters]

When attempting to build gz-physics7 with dartsim 6.14.1, the build fails:

• https://build.osrfoundation.org/job/generic-release-homebrew_triggered_bottle_builder/1503/label=osx_monterey/

/tmp/gz-physics7-20240628-32522-zc6n0e/gz-physics-7.3.0/dartsim/src/Base.hh:44:5: error: invalid token at start of a preprocessor expression
#if DART_VERSION_AT_LEAST(6, 13, 0)
    ^
/usr/local/include/dart/config.hpp:38:3: note: expanded from macro 'DART_VERSION_AT_LEAST'
  DART_VERSION_GE(x, y, z)
  ^
/usr/local/include/dart/config.hpp:19:4: note: expanded from macro 'DART_VERSION_GE'
  (DART_MAJOR_VERSION > x                                                      \
   ^
/usr/local/include/dart/config.hpp:5:28: note: expanded from macro 'DART_MAJOR_VERSION'
#define DART_MAJOR_VERSION @DART_MAJOR_VERSION @
                           ^

It appears that the version number macros at the start of config.hpp.in have a space in between the @ characters, which seems to prevent cmake from matching the variable names when configuring the version number macros. I confirmed by looking at the first few lines of the config.hpp file installed in the dartsim 6.14.1 homebrew bottle:

/* config.hpp. Generated by CMake for dart. */
#pragma once
/* Version number */
#define DART_MAJOR_VERSION @DART_MAJOR_VERSION @
#define DART_MINOR_VERSION @DART_MINOR_VERSION @
#define DART_PATCH_VERSION @DART_PATCH_VERSION @
#define DART_VERSION "6.14.1"
#define DART_DESCRIPTION "Dynamic Animation and Robotics Toolkit."

I believe removing the whitespace should fix it, though it would be better to add a test of the DART_VERSION_AT_LEAST macro, which should catch regressions like this in the future.

---

Before creating a pull request

• Document new methods and classes
• Format new code files using ClangFormat by running make format
• Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

• Set version target by selecting a milestone on the right side
• Summarize this change in CHANGELOG.md
• Add unit test(s) for this change
• Add Python bindings for new methods and classes

[scpeters]

I believe removing the whitespace should fix it, though it would be better to add a test of the DART_VERSION_AT_LEAST macro, which should catch regressions like this in the future.

where would you recommend putting a test for DART_VERSION_AT_LEAST

[jslee02]

Ah, good catch. Thank you for the fix!

I believe removing the whitespace should fix it, though it would be better to add a test of the DART_VERSION_AT_LEAST macro, which should catch regressions like this in the future.

where would you recommend putting a test for DART_VERSION_AT_LEAST

Anywhere in common would make sense to me.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.56%. Comparing base (ed209b2) to head (40b062b).

❗ Current head 40b062b differs from pull request most recent head b03d15a

Please upload reports for the commit b03d15a to get more accurate results.

Additional details and impacted files

@@              Coverage Diff              @@
##           release-6.14    #1820   +/-   ##
=============================================
  Coverage         61.56%   61.56%           
=============================================
  Files               490      490           
  Lines             46021    46021           
=============================================
  Hits              28334    28334           
  Misses            17687    17687           

[scpeters]

Ah, good catch. Thank you for the fix!

I believe removing the whitespace should fix it, though it would be better to add a test of the DART_VERSION_AT_LEAST macro, which should catch regressions like this in the future.

where would you recommend putting a test for DART_VERSION_AT_LEAST

Anywhere in common would make sense to me.

test added in b03d15a to the Logging test since it already had a transitive include of config.hpp via TestHelpers.hpp