Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulate contact points to prevent objects sinking when using ODE - Waiting for comments #1832

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

henriquealrs
Copy link

This is a proposal PR attempting to fix #1654 - Capsule shapes sink through ground with ODE.

I tried to find some functionality in ODE similar to the one from Bullet used in #859 but couldn't find an analogous feature io ODE. So I tried manually implementing a limited contact history and a best effort to keep at least 3 contact points in order to make contact stable.

I worry about performance impact, but tests didn't get anything. I also ran gz-physics tests using DART with my changes and it seemed OK.

There is one failing test test_ForceDependentSlip, but it also fails when using Bullet or DART collision detection, so I think we could reevaluate this test.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using ClangFormat by running make format
  • Build with -DDART_TREAT_WARNINGS_AS_ERRORS=ON and resolve all the compile warnings

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change
  • Add Python bindings for new methods and classes

henriquealrs and others added 30 commits July 6, 2024 09:39
(cherry picked from commit e1e31a7)
(cherry picked from commit 24b2c72)
Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Jeongseok (JS) Lee <[email protected]>
(cherry picked from commit 15c5150)
(cherry picked from commit 75c5565cd6a45bb143ba1fe95137000f2610d03b)
(cherry picked from commit cf20b0e)
(cherry picked from commit 17724f8)
…esn't include backends defs

(cherry picked from commit d12b7aa0e1c2738fbfe817f59bb0424d4161bd02)
(cherry picked from commit a9da476)
(cherry picked from commit c857f6c)
(cherry picked from commit 7918a9c)
(cherry picked from commit b27d020f01ae37fbe63478180d0ae85efc2551b7)
@henriquealrs henriquealrs marked this pull request as draft July 23, 2024 13:44
@henriquealrs henriquealrs changed the title Proposal to fix #1654 Proposal to fix Issue1654 Jul 23, 2024
@henriquealrs henriquealrs changed the title Proposal to fix Issue1654 Accumulate contact points to prevent objects sinking when using ODE - Waiting for comments Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capsule shapes sink through the ground with ODE collision detector
3 participants