Merge pull request #201 from darwin-eu/snake_case_category

categories all as snake case
darwin-eu · Jul 11, 2024 · a4b213f · a4b213f
2 parents c5cc70d + db00838
commit a4b213f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/R/getRoutes.R b/R/getRoutes.R
@@ -46,7 +46,7 @@ getRouteCategories <- function(cdm) {
       ) |>
       dplyr::mutate(route_category = dplyr::if_else(
         is.na(.data$route_category),
-        "unclassified route",
+        "unclassified_route",
         .data$route_category
       )) |>
       dplyr::select("route_category") |>

diff --git a/R/stratifyByRoute.R b/R/stratifyByRoute.R
@@ -71,7 +71,7 @@ stratifyByRouteCategory <- function(x, cdm, keepOriginal = FALSE){
       ) |>
       dplyr::mutate(route_category = dplyr::if_else(
         is.na(.data$route_category),
-        "unclassified route",
+        "unclassified_route",
         .data$route_category
       )) |>
       dplyr::select("concept_id", "route_category") |>

diff --git a/R/subsetOnRouteCategory.R b/R/subsetOnRouteCategory.R
@@ -69,7 +69,7 @@ subsetOnRouteCategory <- function(x, cdm, routeCategory){
       ) |>
       dplyr::mutate(route_category = dplyr::if_else(
         is.na(.data$route_category),
-        "unclassified route",
+        "unclassified_route",
         .data$route_category
       )) |>
       dplyr::filter(.data$route_category %in% .env$routeCategory) |>

diff --git a/tests/testthat/test-dbms.R b/tests/testthat/test-dbms.R
@@ -19,7 +19,7 @@ test_that("redshift", {
 
   expect_no_error(routeCat <- getRouteCategories(cdm))
   expect_true(all(routeCat %in%
-                  c(doseFormToRoute$route_category, "unclassified route")))
+                  c(doseFormToRoute$route_category, "unclassified_route")))
   # alphabetical order
   expect_identical(routeCat,
                    sort(getRouteCategories(cdm)))

diff --git a/tests/testthat/test-subsetOnRouteCategory.R b/tests/testthat/test-subsetOnRouteCategory.R
@@ -12,7 +12,7 @@ test_that("subset on route category", {
 
   ing_codes_sub <- subsetOnRouteCategory(ing_codes,  cdm, "oral")
 
-  ing_codes_sub2 <- subsetOnRouteCategory(ing_codes,  cdm, "unclassified route")
+  ing_codes_sub2 <- subsetOnRouteCategory(ing_codes,  cdm, "unclassified_route")
   expect_identical(ing_codes, ing_codes_sub2)
 
   # expected errors