Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #29 [ Show open files used by a process ] #49

Merged
merged 4 commits into from
Nov 13, 2018

Conversation

sdeepaknarayanan
Copy link
Collaborator

Added the Open Files Displaying, Feature Storming

@darxtrix
Copy link
Owner

darxtrix commented Nov 12, 2018

Thanks for the contribution again. Can you please add a screenshot displaying opened files by a process ?

@darxtrix
Copy link
Owner

darxtrix commented Nov 12, 2018

@deeps-nars Please reference the issue by putting a link in the PR body for quick reference. It would be great if you can write the PR heading like "Fixes #29 [ ]" Github will automatically reference the issue if you put Fixes# in PR body and when the PR is merged Github will close the issue for us also :) .A little detailed heading will be better for me for understanding when seeing the list of PRs. Doing that for now :)

@darxtrix darxtrix changed the title Issue 29 Fixes #29 [ Show open files used by a process ] Nov 12, 2018
@sdeepaknarayanan
Copy link
Collaborator Author

sdeepaknarayanan commented Nov 12, 2018

@darxtrix, It works with terminal resizing too.
p4
p1
The popup box displays both the number of ports getting used, as well as the number of open files and displays them. In response to your previous comment on PR Body, I'll do that from now on. Thanks :)

@darxtrix darxtrix merged commit a57982b into darxtrix:master Nov 13, 2018
darxtrix added a commit that referenced this pull request Nov 13, 2018
@darxtrix
Copy link
Owner

Merged after some refactoring, thanks @deeps-nars ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants