fix(backendconnection): add annotation to prevent ArgoCD pruning #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For clusters managed by ArgoCD, we need to prevent ArgoCD to prune Kubernetes resources necessary for the OTel collector managed by the operator. If pruning is enabled in ArgoCD, it will automatically delete resources which have no owner reference. This applies to all cluster-scoped resources which the operator creates (since cluster-scoped resource cannot be owned by namespace-scoped resources). In particular, this affects the cluster role & cluster role binding. References: * argoproj/argo-cd#4764 (comment) this indicates that only top level resources are pruned (which is basically the same as resources without an owner reference). * The docs for preventing this on a resource level are here: https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#no-prune-resources
basti1302
force-pushed
the
prevent-argo-cd-from-pruning-cluster-scope-resources
branch
from
4321826
to
9eda835
Compare
|
basti1302
deleted the
prevent-argo-cd-from-pruning-cluster-scope-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clusters managed by ArgoCD, we need to prevent ArgoCD to prune
Kubernetes resources necessary for the OTel collector managed by the
operator. If pruning is enabled in ArgoCD, it will automatically delete
resources which have no owner reference. This applies to all
cluster-scoped resources which the operator creates (since
cluster-scoped resource cannot be owned by namespace-scoped resources).
In particular, this affects the cluster role & cluster role binding.
References:
OwnerReferencenot deleted when removed from Helm Chart argoproj/argo-cd#4764 (comment)this indicates that only top level resources are pruned (which is
basically the same as resources without an owner reference).
https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#no-prune-resources