Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): fix test case for updating the collector configuration #158

Merged
merged 1 commit into from
Sep 26, 2024
Merged

test(e2e): fix test case for updating the collector configuration #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/dash0_monitoring_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func updateEndpointOfDash0MonitoringResource(
) {
updateDash0MonitoringResource(
namespace,
fmt.Sprintf("{\"spec\":{\"export\":{\"http\":{\"endpoint\":\"%s\"}}}}", newEndpoint),
fmt.Sprintf("{\"spec\":{\"export\":{\"dash0\":{\"endpoint\":\"%s\"}}}}", newEndpoint),
)
}

Expand Down
7 changes: 4 additions & 3 deletions test/e2e/e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,9 +747,10 @@ var _ = Describe("Dash0 Kubernetes Operator", Ordered, func() {
By("updating the Dash0 monitoring resource endpoint setting")
newEndpoint := "ingress.us-east-2.aws.dash0-dev.com:4317"
updateEndpointOfDash0MonitoringResource(applicationUnderTestNamespace, newEndpoint)
// Note: updating the endpoint in this way will lead to telemetry from the applications under test no longer
// being sent to otlp-sink. This is not relevant for this test case, but might be an issue if we ever add
// more tests to this suite after this one.
defer func() {
// reset the endpoint to the default after this test
updateEndpointOfDash0MonitoringResource(applicationUnderTestNamespace, defaultEndpoint)
}()

By("waiting for self-monitoring metrics")
Eventually(func(g Gomega) {
Expand Down