feat(controller): revert instrumentation when Dash0 resource is deleted #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
5 times, most recently
from
240a7de
to
14cd907
Compare
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
from
14cd907
to
7d59f26
Compare
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
2 times, most recently
from
7dcb8b2
to
3235ebb
Compare
* add read permissions for namespaces * remove all permissions (get, list, watch) for pods Also: Order the kubebuilder:rbac statements in dash0_controller alphabetically.
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
from
3235ebb
to
e135648
Compare
This helps to consolidate the instrument/revert logic into one method, instead of having one method per resource type.
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
from
72f08ca
to
ad1e5cd
Compare
This happens both when a workload is already instrumented, but also for replica sets that are owned by a deployment, so we should mention this in the corresponding log message and event.
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
from
ab88e01
to
ef50d2b
Compare
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
from
f828e0e
to
449903f
Compare
Also: prefix all labels with dash0.com and use kebap case instead of dot-separated notation for label names.
basti1302
force-pushed
the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
from
7f3b7f6
to
612d403
Compare
|
basti1302
deleted the
remove-instrumentation-when-dash0-custom-resource-is-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.