chore: add tracker to editor's paste and OTel config load through URL #138
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -77,6 +78,9 @@ export default function Editor({ locked, setLocked }: { locked: boolean; setLock | |||
| // /restore page. Without this we ran into return URL problems with GitHub | |||
| // and Google as our return URL can be **very** long. | |||
| localStorage.setItem("config-restore", config); | |||
| if (config !== editorBinding.fallback) { | |||
There was a problem hiding this comment.
Issue: We must only report this event once on the initial page load
There was a problem hiding this comment.
Initial page load even with default config? I assumed load the page with different config that stored in URL. @bripkens
There was a problem hiding this comment.
I assumed load the page with different config that stored in URL.
Yes, correct. It should be both conditions: Initial load and when the config is different from the default one.
src/contexts/EditorContext.tsx
Outdated
| @@ -240,6 +241,10 @@ export const EditorProvider = ({ children }: { children: ReactNode }) => { | |||
| }; | |||
| findSymbols(docObject, "", wordAtCursor.word, cursorOffset); | |||
| }); | |||
|
|
|||
| editorRef.current.onDidPaste(() => { | |||
| track("Paste", { location: "Editor" }); | |||
There was a problem hiding this comment.
We have just been thinking about this event. This is likely too fine-grained tracking and it is hard to interpret. Let's delete this event (sorry for the back and forth).
src/contexts/EditorContext.tsx
Outdated
| @@ -240,6 +241,10 @@ export const EditorProvider = ({ children }: { children: ReactNode }) => { | |||
| }; | |||
| findSymbols(docObject, "", wordAtCursor.word, cursorOffset); | |||
| }); | |||
|
|
|||
| editorRef.current.onDidPaste(() => { | |||
There was a problem hiding this comment.
Great to see how this works. We can make use of this handler for function for this task :)
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.