Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear duplicated codes #157

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Clear duplicated codes #157

merged 4 commits into from
Oct 31, 2023

Conversation

roshan-gh
Copy link
Contributor

  • clear node-types duplicated codes in order to change node styles in future from one file

@roshan-gh roshan-gh self-assigned this Oct 31, 2023
@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 4:46pm

bripkens
bripkens approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@bripkens bripkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Well done! ❤️

packages/otelbin/src/components/react-flow/ReactFlow.tsx Outdated
import ReceiversNode from "./node-types/ReceiversNode";
import ProcessorsNode from "./node-types/ProcessorsNode";
import ExportersNode from "./node-types/ExportersNode";
// import ReceiversNode from "./node-types/ReceiversNode1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Remove this commented code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my mistake, sure @bripkens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bripkens comments removed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bripkens bripkens merged commit 62509f7 into main Oct 31, 2023
23 of 27 checks passed
@bripkens bripkens deleted the clear-duplicated-codes branch October 31, 2023 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bripkens bripkens bripkens approved these changes

Assignees

@roshan-gh roshan-gh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roshan-gh @bripkens