Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages for built-in configuration JSON schema #184

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

mmanciop
Copy link
Member

@mmanciop mmanciop commented Nov 8, 2023

No description provided.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 10:42am

@mmanciop
Copy link
Member Author

mmanciop commented Nov 8, 2023

We should make the documentation URLs clickable, or ideally put them behind an icon. But the schema changes are IMO good to merge regardless @bripkens.

@bripkens bripkens force-pushed the improve-schema-error-messages branch from f6e1109 to 8048cd6 Compare November 8, 2023 10:41
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmanciop mmanciop merged commit 5eccfe4 into main Nov 8, 2023
9 checks passed
@mmanciop mmanciop deleted the improve-schema-error-messages branch November 8, 2023 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants