feat: serverSide validation error markers #190
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -99,6 +102,28 @@ export function validateOtelCollectorConfigurationAndSetMarkers( | |||
| } | |||
| if (!totalErrors.jsYamlError) { | |||
| customValidate(mainItemsData, serviceItemsData, errorMarkers, totalErrors, configData); | |||
| const serverSideErrorElement = findErrorElement(serverSideValidationPath, parsedYamlConfig); | |||
There was a problem hiding this comment.
Suggestion: Add tests for this :)
There was a problem hiding this comment.
All the functions that used for serverSide markers are already have tests. (used the same functions as for ajv error markers) @bripkens
There was a problem hiding this comment.
So if that is the case, does that mean that this new code can be deleted and there will be a red test? :)
|
@bripkens removed server-side word |
|
We need to deduplicate errors on the same path: if two errors are found on the same path, the server-side error takes precedence, see attached screenshot (repro). 
|
bripkens
force-pushed
the
server-side-validation-marker
branch
from
db19955
to
2bc1570
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.