191 flexible validation error console height #193
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -179,7 +179,7 @@ export default function Editor({ locked, setLocked }: { locked: boolean; setLock | |||
| )} | |||
| </div> | |||
| {viewMode !== "pipeline" && <ValidationErrorConsole errors={totalValidationErrors} font={firaCode} />} | |||
| {viewMode == "both" && <ResizeBar onWidthChange={onWidthChange} />} | |||
There was a problem hiding this comment.
Question: Why was this condition removed? Now the resize bar is shown when the editor is hidden.
| @@ -42,58 +51,123 @@ export default function ValidationErrorConsole({ errors, font }: { errors?: IErr | |||
| } | |||
| }, [errorCount, warningsCount]); | |||
|
|
|||
| const onHeightChange = useCallback((newHeight: number) => { | |||
There was a problem hiding this comment.
Question: Why do we need this useCallback fn? As far as I can see, we could just use setHeight within the useEffect call below.
There was a problem hiding this comment.
fixed and pushed. @bripkens
| {errors?.jsYamlError?.mark?.line && <ErrorMessage jsYamlError={errors?.jsYamlError} font={font} />} | ||
| </div> | ||
| )} | ||
| <> |
There was a problem hiding this comment.
Question: Why do we need this fragment?
There was a problem hiding this comment.
fixed and pushed. @bripkens
…alidation-error-console-height
| })} | ||
| {errors?.jsYamlError?.mark?.line && <ErrorMessage jsYamlError={errors?.jsYamlError} font={font} />} | ||
| <AutoSizer> | ||
| {({ height }) => ( |
There was a problem hiding this comment.
Question: Why do we need AutoSizer here?
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.