Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recipes in OTelBin #209

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Recipes in OTelBin #209

wants to merge 2 commits into from

Conversation

bripkens
Copy link
Member

@vercel Vercel
Copy link

vercel bot commented Nov 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 8:40am

@socket-security Socket Security
Copy link

socket-security bot commented Nov 20, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/js-yaml 4.0.9 None +0 9.12 kB
@types/cli-progress 3.11.5 None +2 4.01 MB types
cli-progress 3.12.0 None +0 62.2 kB andidittrich
zod 3.22.4 None +0 628 kB colinmcd94
dotenv 16.3.1 environment +0 71.6 kB motdotla
typescript 5.3.2 None +0 32 MB typescript-bot

mmanciop
mmanciop requested changes Nov 21, 2023
View reviewed changes
packages/otelbin-recipes/recipes/test.yaml
title: 'Foo'
author: 'Bar'
description: 'Hello World'
config: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should use a similar markup as in supported-distributions.json to optionally allow-list distributions and version ranges

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH though I would love for us to have a recipe first that is not supported by all distros :)

Copy link
Member

@mmanciop mmanciop Nov 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a fair share of ADOT's wouldn't.

Also, any use of the debug exporter breaks 0.85.0 (or so) and below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the difference between the invalid state generated right now and an excluded range from the perspective of the user? Maybe I am missing something.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nice to have: tags on recipes could be super useful as the number of possible recipes grows so it's easy to filter, for example, by anything related to "aws" or "mysql", etc

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanciop mmanciop mmanciop requested changes

@smithclay smithclay smithclay left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bripkens @smithclay @mmanciop @marcelbirkner