-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server side env var interpolation #285
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more hardened var detection was already specc'd in the #156 issue
@@ -250,3 +252,32 @@ export function selectConfigType(config: string) { | |||
return config; | |||
} | |||
} | |||
|
|||
export function extractVariables(inputString: string): string[] { | |||
const variableRegex = /\${([^}]+)}/g; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spec of the env var detection is here: #156
…v-var-interpolation
…v-var-interpolation
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 6 New issues |
This pull request enhances server-side validation by introducing support for environment variable interpolation. It extends the existing configuration resolver logic to recognize and interpolate environment variables specified in the configuration. The changes ensure that environment variables can be seamlessly incorporated into the validation process, enhancing the flexibility and accuracy of server-side validation.