Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve output when validation via distros #299

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

bripkens
Copy link
Member

Why

The current parsing logic for error messages leaves much to be desired, typically only resulting in something like this:

The provided configuration is invalid - failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:

What

  • Improve the parsing logic.
  • Add tests.

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 5:02pm

Copy link

socket-security bot commented Feb 10, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] Transitive: environment, filesystem, unsafe +50 5.66 MB types
npm/[email protected] environment, filesystem, unsafe Transitive: eval, network, shell +282 55.1 MB kul

View full report↗︎

# Why
The current parsing logic for error messages leaves much to be desired,
typically only resulting in something like this:

```
The provided configuration is invalid - failed to get config: cannot unmarshal the configuration: 1 error(s) decoding:
```

# What
 - Improve the parsing logic.
 - Add tests.
@bripkens bripkens force-pushed the distro-validation-error-improvements branch from 61fd9d9 to 7d9499c Compare February 10, 2024 17:01
Copy link

sonarcloud bot commented Feb 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bripkens bripkens merged commit 9496794 into main Feb 10, 2024
46 of 47 checks passed
@bripkens bripkens deleted the distro-validation-error-improvements branch February 10, 2024 18:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant