Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): ensure all supported versions are reachable in dropdown #316

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

mmanciop
Copy link
Member

Set max height of the version dropdown to 50% of viewport, so that even on small resolutions we can ensure that all versions are reachable through scrolling.

Fixes #310

@mmanciop mmanciop requested a review from bripkens April 18, 2024 15:53
@mmanciop mmanciop self-assigned this Apr 18, 2024
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
otelbin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 4:56pm

Set max height of the version dropdown to 50% of viewport, so that even on small resolutions we can ensure that all versions are reachable through scrolling.

Fixes #310
@mmanciop mmanciop disabled auto-merge April 18, 2024 16:55
@mmanciop mmanciop enabled auto-merge April 18, 2024 16:55
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mmanciop mmanciop merged commit 1fa5523 into main Apr 18, 2024
9 checks passed
@mmanciop mmanciop deleted the fix-version-dropdown branch April 18, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collector Version Selection Dropdown cut off at top
2 participants