Generate spans within our validation lambdas #326
Conversation
bripkens
commented
May 14, 2024
•
bripkens
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bripkens
force-pushed
the
lambda-telemetry
branch
from
4a82fac
to
41df99b
Compare
bripkens
force-pushed
the
lambda-telemetry
branch
from
41df99b
to
2d1af1a
Compare
bripkens
force-pushed
the
lambda-telemetry
branch
from
2d1af1a
to
852b661
Compare
…ntation is not an option
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@expo/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected] |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
bripkens
force-pushed
the
lambda-telemetry
branch
from
24c198c
to
0948572
Compare
bripkens
force-pushed
the
lambda-telemetry
branch
from
8a326b4
to
8da7921
Compare
bripkens
force-pushed
the
lambda-telemetry
branch
from
8da7921
to
41eb8c2
Compare
bripkens
force-pushed
the
lambda-telemetry
branch
from
18356f4
to
ae9bb4a
Compare
| @@ -23,7 +24,102 @@ interface Env { | |||
|
|
|||
| const distroName = process.env.DISTRO_NAME; | |||
|
|
|||
| export const validateAdot = async (otelcolRealPath: string, configPath: string, env: Env): Promise<void> => { | |||
| /** | |||
| * Using CommonJS export to allow for AWS lambda layer to work as per the | |||
There was a problem hiding this comment.
large diff. Only thing changed here is the ESM -> CommonJS migration for auto-instrumentation support.
| const { OTLPTraceExporter } = require("@opentelemetry/exporter-trace-otlp-proto"); | ||
| const { MeterProvider, MeterProviderOptions } = require("@opentelemetry/sdk-metrics"); | ||
|
|
||
| function defaultConfigureInstrumentations() { |
There was a problem hiding this comment.
For the most part, this is a copy of the official Node.js lambda layer's wrapper file. Unfortunately reusing as dependency is not possible, because it is not published as an NPM package.
There was a problem hiding this comment.
suggestion: How about adding a comment to that extent as a maintenance note? So we know which code we vendored-in here an why.
bripkens
changed the title
| const { OTLPTraceExporter } = require("@opentelemetry/exporter-trace-otlp-proto"); | ||
| const { MeterProvider, MeterProviderOptions } = require("@opentelemetry/sdk-metrics"); | ||
|
|
||
| function defaultConfigureInstrumentations() { |
There was a problem hiding this comment.
suggestion: How about adding a comment to that extent as a maintenance note? So we know which code we vendored-in here an why.
bripkens
force-pushed
the
lambda-telemetry
branch
from
e483d98
to
c034152
Compare
|
