switch to samuelmeuli action

dashpay · Dec 2, 2024 · fcdcd4e · fcdcd4e
1 parent bc88d36
commit fcdcd4e
Showing 1 changed file with 11 additions and 10 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -163,21 +163,22 @@ jobs:
         if: contains(matrix.target, 'apple-darwin')
         run: codesign --timestamp --sign "${{ steps.import_certs.outputs.identity }}" dist/dash-evo-tool-${{ matrix.platform }}.${{ matrix.release-ext }}
 
-      # Notarize the .dmg for macOS
+      # Notarize the .dmg for macOS using samuelmeuli/action-notarize
       - name: Notarize .dmg
         if: contains(matrix.target, 'apple-darwin')
-        uses: apple-actions/macos-notarize@v1
+        uses: samuelmeuli/action-notarize@v1
         with:
-          app-path: dist/dash-evo-tool-${{ matrix.platform }}.${{ matrix.release-ext }}
-          primary-bundle-id: com.yourcompany.dash-evo-tool
+          appPath: dist/dash-evo-tool-${{ matrix.platform }}.${{ matrix.release-ext }}
+          bundleId: dcg.dash-evo-tool
+          #ascProvider: ${{ secrets.APPLE_TEAM_ID }} # Optional, remove if not needed
         env:
-          AC_USERNAME: ${{ secrets.APPLE_ID }}
-          AC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
+          NOTARIZE_USERNAME: ${{ secrets.APPLE_ID }}
+          NOTARIZE_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
 
-      # Staple the notarization ticket to the .dmg for macOS
-      - name: Staple Notarization Ticket
-        if: contains(matrix.target, 'apple-darwin')
-        run: xcrun stapler staple dist/dash-evo-tool-${{ matrix.platform }}.${{ matrix.release-ext }}
+      # Stapling is handled by the action-notarize, so this step is optional
+      # - name: Staple Notarization Ticket
+      #   if: contains(matrix.target, 'apple-darwin')
+      #   run: xcrun stapler staple dist/dash-evo-tool-${{ matrix.platform }}.${{ matrix.release-ext }}
 
       - name: Package release
         run: "${GITHUB_WORKSPACE}/scripts/pack.sh ${{ env.VERSION }} ${{ matrix.platform }} ${{ matrix.ext }}"