Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Arabic decimals #1168

Closed
wants to merge 3 commits into from
Closed

Fix: Arabic decimals #1168

wants to merge 3 commits into from

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jul 24, 2023

In Arabic locales, there is a different comma character used as a decimal separator, which is distinct from the comma in other locales. This causes a crash in the Amount Input control.

Issue being fixed or feature implemented

  • Improve formatFiatWithoutComma to make it more robust
  • Some other RTL fixes

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

@Syn-McJ Syn-McJ self-assigned this Jul 24, 2023
@Syn-McJ Syn-McJ closed this Jul 27, 2023
@Syn-McJ Syn-McJ deleted the fix-arabic-decimals branch July 27, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants