Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Username | Submit Request #1183

Merged
merged 8 commits into from
Aug 22, 2023
Merged

Request Username | Submit Request #1183

merged 8 commits into from
Aug 22, 2023

Conversation

hadia
Copy link
Contributor

@hadia hadia commented Aug 15, 2023

Issue being fixed or feature implemented

As a user who has submitted a username request, I would like the information saved to the network.

  • The user should be able to submit the request without verifying their identity”now dialog is closed when clicking Skip and nothing happens. We have to raise a Confirmation instead”
  • The user should be able to see the cost of the request in Dash and in fiat
  • The user should be directed back to the More screen after submitting the request
  • The status of the request should be updated to “Requested” on the More screen
  • The start and end of the voting period should be shown on the More screen
  • A system message should be shown to the user that the request was successful

Related PR's and Dependencies

Screenshots / Videos

How Has This Been Tested?

  • QA (Mobile Team)

Checklist:

  • I have performed a self-review of my own code and added comments where necessary
  • I have added or updated relevant unit/integration/functional/e2e tests

Syn-McJ
Syn-McJ requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required

wallet/src/de/schildbach/wallet/ui/username/voting/ConfirmUsernameRequestDialogFragment.kt Outdated Show resolved Hide resolved
wallet/src/de/schildbach/wallet/ui/username/voting/RequestUserNameViewModel.kt Outdated Show resolved Hide resolved
wallet/src/de/schildbach/wallet/ui/username/voting/RequestUsernameFragment.kt Outdated Show resolved Hide resolved
@hadia hadia requested a review from Syn-McJ August 15, 2023 09:50
Syn-McJ
Syn-McJ approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Syn-McJ Syn-McJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

HashEngineering
HashEngineering requested changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two things to look at before I approve.

wallet/src/de/schildbach/wallet/ui/more/MoreFragment.kt Outdated Show resolved Hide resolved
wallet/src/de/schildbach/wallet/ui/username/voting/RequestUserNameViewModel.kt Outdated Show resolved Hide resolved
@hadia
Merge branch 'dashpay' into hadia/NMA-1502
c2b3554 
# Conflicts:
#	wallet/res/values/strings.xml
#	wallet/src/de/schildbach/wallet/ui/dashpay/DashPayViewModel.kt
@hadia
fix : merge to dashpay
36cd074
@hadia
fix : hide join dash pay
6386279
@hadia
fix : code comments
c28a862
HashEngineering
HashEngineering requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two items noted in my last review have yet to be fixed in this PR.

@HashEngineering HashEngineering merged commit 6473c35 into dashpay Aug 22, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the hadia/NMA-1502 branch August 23, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samettek samettek samettek approved these changes

@Syn-McJ Syn-McJ Syn-McJ approved these changes

@HashEngineering HashEngineering HashEngineering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hadia @HashEngineering @Syn-McJ @samettek