refactor: avoid cs_main #5650
Merged
refactor: avoid cs_main #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please rebase. |
PastaPastaPasta
force-pushed
the
refac/csmain
branch
from
76c0ec8 to
0bdfbf9
Compare
UdjinM6
requested changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Avoid locking cs_main in high volume call locations; I'm not fully sure the removal in signature_shares.cpp is okay; but it compiles.
What was done?
Removed or reduced scope
How Has This Been Tested?
Running with enable-debug
Breaking Changes
Should be done
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.