Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: intermittent failures in feature_governance.py #5868

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix: intermittent failures in feature_governance.py #5868

merged 2 commits into from
Feb 13, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 11, 2024

Issue being fixed or feature implemented

Should fix failures like https://gitlab.com/dashpay/dash/-/jobs/6107697452

What was done?

See inline comments

How Has This Been Tested?

Run lots of feature_governance.py in parallel multiple times

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 added this to the 20.1 milestone Feb 11, 2024
ogabrielides
ogabrielides previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

knst
knst reviewed Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce issue locally, but LGTM except a mentioned nit

@UdjinM6 @knst
refactor: apply suggestions
2ec4e55 
Co-authored-by: Konstantin Akimov <[email protected]>
@UdjinM6 UdjinM6 dismissed stale reviews from PastaPastaPasta and ogabrielides via 2ec4e55 February 12, 2024 19:19
knst
knst approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ogabrielides
ogabrielides approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

@PastaPastaPasta PastaPastaPasta merged commit 6991337 into dashpay:develop Feb 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst knst approved these changes

@ogabrielides ogabrielides ogabrielides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
4 participants
@UdjinM6 @ogabrielides @knst @PastaPastaPasta