Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: intermittent failures in feature_asset_locks.py #5875

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: intermittent failures in feature_asset_locks.py #5875

merged 1 commit into from
Feb 15, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Feb 15, 2024

Issue being fixed or feature implemented

fix failures like https://gitlab.com/dashpay/dash/-/jobs/6175160403

What was done?

use minimumAmount option in listunspent rpc call to avoid picking coins that are too small for asset lock txes

How Has This Been Tested?

run feature_asset_locks.py

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@UdjinM6 UdjinM6 added this to the 20.1 milestone Feb 15, 2024
PastaPastaPasta
PastaPastaPasta approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

knst
knst approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit fa4ced9 into dashpay:develop Feb 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst knst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @knst @PastaPastaPasta