Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial: use WITH_LOCK when possible #5879

Merged
merged 1 commit into from
Feb 16, 2024
Merged

trivial: use WITH_LOCK when possible #5879

merged 1 commit into from
Feb 16, 2024

Conversation

PastaPastaPasta
Copy link
Member

Issue being fixed or feature implemented

Trivial PR for minor issue found when reviewing generalized EHF

What was done?

Use WITH_LOCK

How Has This Been Tested?

Building Locally

Breaking Changes

None

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@PastaPastaPasta PastaPastaPasta added this to the 20.1 milestone Feb 16, 2024
UdjinM6
UdjinM6 approved these changes Feb 16, 2024
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

knst
knst approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@knst knst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@PastaPastaPasta PastaPastaPasta merged commit 3be3c1d into dashpay:develop Feb 16, 2024
8 checks passed
@PastaPastaPasta PastaPastaPasta deleted the trivial-withlock branch February 16, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@knst knst knst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.1
Development

Successfully merging this pull request may close these issues.
3 participants
@PastaPastaPasta @knst @UdjinM6