Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(strategy-tests): create some identity transitions rather than none on error #2058

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Aug 14, 2024

Issue being fixed or feature implemented

In strategy tests, when creating identity state transitions, if there was an error creating one transition but success in creating others, we would return 0 transitions.

What was done?

Now we return a vector of results from create_identity_state_transitions and return a vector of errors from state_transitions_for_block.

How Has This Been Tested?

TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia changed the title fix: create some identity transitions rather than none on error fix(strategy-tests): create some identity transitions rather than none on error Aug 14, 2024
ogabrielides
ogabrielides previously approved these changes Aug 15, 2024
Copy link
Contributor

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@shumkov shumkov changed the base branch from v1.1-dev to master August 25, 2024 07:39
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 07:39
@pauldelucia pauldelucia changed the base branch from master to v1.2-dev August 25, 2024 11:14
@pauldelucia pauldelucia marked this pull request as draft August 25, 2024 12:02
@pauldelucia pauldelucia marked this pull request as ready for review August 27, 2024 05:36
@shumkov shumkov changed the base branch from v1.2-dev to master September 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants