fix: return checksum of SignRequestId

dashpay · Dec 14, 2023 · f39c8f0 · f39c8f0
1 parent b90f63a
commit f39c8f0
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/types/vote.go b/types/vote.go
@@ -131,11 +131,7 @@ func VoteExtensionRequestID(ext *tmproto.VoteExtension, height int64, round int3
 
 	if ext.XSignRequestId != nil && ext.XSignRequestId.Size() > 0 {
 		if ext.Type == tmproto.VoteExtensionType_THRESHOLD_RECOVER_RAW {
-			// TODO to avoid blind signing, we should have crypto.Checksum(signRequestID) here
-			buf := make([]byte, 32)
-			// this will ensure sign request ID has exactly 32 bytes
-			copy(buf, ext.GetSignRequestId())
-			return buf, nil
+			return crypto.Checksum(ext.GetSignRequestId()), nil
 		}
 		return nil, ErrVoteExtensionTypeWrongForRequestID
 	}