refactor(abci)!: move Events from FinalizeBlock to ResponseProcessProposal #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There is a scenario where the App (Drive) has already finalized the block, while Tenderdash State didn’t record it before crash. It means that AppState.Height == TenderdashState.Height+1.
When recovering after crash/error, this sometimes causes
ERROR: failed to start node: error on replay: could not find results for height #157
.What was done?
How Has This Been Tested?
error on replay: could not find results for height
on local devnet, runningv0.14-dev
branch - reproducedBreaking Changes
Checklist:
For repository code-owners and collaborators only