test(consensus): fix flaky TestEmitNewValidBlockEventOnCommitWithoutBlock

[lklimek]

Issue being fixed or feature implemented

TestEmitNewValidBlockEventOnCommitWithoutBlock is flaky.

In the tested scenario, Tenderdash changes round step to Precommit, and then quickly advances to ApplyCommit step.

{"level":"debug","module":"consensus","module":"consensus","message":"updating state data step to Precommit on EnterPrecommitAction"}
{"level":"debug","module":"consensus","module":"consensus","commit_round":1,"new_height":1,"height":1,"round":1,"step":6,"message":"entering commit step"}
{"level":"debug","module":"consensus","module":"consensus","commit":"8E4B2F2E5D2E168704B334B47F2FE394F1674E181A79E79FDA50AC03AC08618D","proposal":"","message":"commit is for a block we do not know about; set ProposalBlock=nil"}
{"level":"debug","module":"consensus","module":"consensus","message":"updating state data step to ApplyCommit on EnterCommitAction"}

This makes the test flaky, as time between these steps is too small to reliably check assertions in the test.

What was done?

Accept both steps as part of the test.

How Has This Been Tested?

go test -count 1000 ./internal/consensus/ -run TestEmitNewValidBlockEventOnCommitWithoutBlock -test.v 

Breaking Changes

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

[shumkov]

👍