Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): ineffective PROXY_APP and ABCI env in Docker image #805

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Jun 26, 2024

Issue being fixed or feature implemented

Env variables PROXY_APP and ABCI are ignored when using Docker images. It is caused by recent changes to the config file format.

What was done?

Fixed issue in entrypoint.

How Has This Been Tested?

Using rs-tenderdash-abci tests.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the title fix(docker): ineffective PROXY_APP and ABCI env in entrypoint fix(docker): ineffective PROXY_APP and ABCI env in Docker image Jun 26, 2024
@lklimek lklimek enabled auto-merge (squash) June 26, 2024 10:59
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lklimek lklimek merged commit 9554ac1 into v1.0-dev Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants