fix: active validators not always connected to each other #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklimek
force-pushed
the
fix/validator-conn-executor-not-started
branch
from
eb623c4 to
76c41c3
Compare
lklimek
added a commit
that referenced
this pull request
Jul 29, 2024
* feat!: replace dash core quorum sign with quorum platformsign (#828) * feat: replace dash core quorum sign with quorum platformsign * chore: fix Docker legacy warning * test(e2e): fix e2e quorum sign mock * build(deps): update dashd-go to v0.25.0 * build(deps): Bump bufbuild/buf-setup-action from 1.33.0 to 1.35.0 (#841) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.33.0 to 1.35.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.33.0...v1.35.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(dependabot): run dependabot on default branch, not master (#843) * chore(release): update changelog and version to 1.1.0-dev.1 (#842) * fix: address already in use (#845) * fix: address already in use * fix: always sleep * fix: active validators not always connected to each other (#844) * chore(dash): decrease log verbosity in validator conn executor * fix(node): validator conn executor not started correctly * fix: panic on full node * fix: dash dialer fails to lookup nodes in addressbook * chore(release): update changelog and version to 1.1.0-dev.2 (#846) * feat(abci): allow overriding genesis time in InitChain (#847) * chore(release): update changelog and version to 1.1.0-dev.3 (#848) * fix: validators form islands on genesis (#850) * chore(release): update changelog and version to 1.1.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Shumkov <[email protected]>
lklimek
added a commit
that referenced
this pull request
Jul 29, 2024
* chore(dash): decrease log verbosity in validator conn executor * fix(node): validator conn executor not started correctly * fix: panic on full node * fix: dash dialer fails to lookup nodes in addressbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There is a
ValidatorConnExecutorservice that ensures that each active validator is connected to at least some other validators that are members of the same quorum.Unfortunately, after some backports/refactorings, this service is not started correctly anymore.
What was done?
How Has This Been Tested?
Start e2e tests and monitor logs
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only