Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better partition string escaping #180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gallamine
Copy link

Based on the #179 this PR adds string escaping to non-integer partition values. Partitions like:

forecasted_business_day=2021-05-27

will now be wrapped like

forecasted_business_day="2021-05-27"

when executing the SQL

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #180 (cdc603e) into main (bbfee5f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         2209      2210    +1     
  Branches       303       303           
=========================================
+ Hits          2209      2210    +1     
Impacted Files Coverage Δ
dask_sql/input_utils/hive.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbfee5f...cdc603e. Read the comment docs.

@nils-braun
Copy link
Collaborator

Thank you so much @gallamine! I have added some thoughts to gallamine#1 on that and #181. I think we need to solve both issues at the same time.

@GPUtester
Copy link

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants