Drop Python 3.8, in accordance with NEP29 recommendation #315
Conversation
|
I don't understand why the GPU CI is returning build failures, when the github actions CI manages to create its environment just fine. @jakirkham do you have any debugging tips? I'm not finding a lot of useful information in the Jenkins console output. |
There was a problem hiding this comment.
@GenevieveBuckley sorry for the GPU CI confusions - looks like the python 3.11 build failed because there currently aren't python 3.11 images for dask-image's GPU CI being published (more info in my comment below); the 3.9 tests do look legitimate though, I'll pull locally and try to reproduce
There was a problem hiding this comment.
@GenevieveBuckley sorry for the GPU CI confusions - looks like the python 3.11 build failed because there currently aren't python 3.11 images for dask-image's GPU CI being published (more info in my comment below); the 3.9 tests do look legitimate though, I'll pull locally and try to reproduce
|
Did some digging into the python 3.9 failures on GPU and looks like those are also related to the images - since we are bumping the conda environment files that the images are built against in this PR, they don't yet reflect some of the changes that were made to unblock tests, specifically the Dask version bump. I will note that locally I was able to unblock these failures by modifying the dask-image install command in the GPU test script: dask-image/continuous_integration/gpuci/build.sh Lines 46 to 47 in d571db7 As a |
Python 3.11 images are not available yet. So stick to Python 3.10 images until that changes. Co-authored-by: Charles Blackmon-Luca <[email protected]>
|
After talking with Charles about this offline, it sounds like this CI issue should go away after these changes are in |
|
Thanks Genevieve and Charles! 🙏 |
|
Submitted PR ( #317 ) to retest gpuCI now that this is merged |
|
Fixed one more Python version constrain in PR ( #336 ) |
Closes #314
This PR drops support for python 3.8
The NEP 29 recommendation is to drop support for python 3.8 on April 14th 2023. We're about a month past that date now, so we're dropping support for it.
The second reason for doing this now is that our python 3.8 CI test environments are starting to have some problems with dependency version mismatches, and it's not a good use of maintainer time to figure out those issues when we're about to drop support for python 3.8 anyway.