Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeled comprehension channel axis #381

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joshua-gould
Copy link

Support trailing channel axis in labeled_comprehension

@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

@m-albert
Copy link
Collaborator

m-albert commented Jul 12, 2024 via email

@m-albert
Copy link
Collaborator

@joshua-gould I'd agree that supporting a channel axis could be useful here. However I've just seen that this isn't implemented upstream in scipy.ndimage and generally we'd try to avoid deviating from the ndimage API if possible.

Would you have opinions here @GenevieveBuckley @jakirkham ?

@jakirkham
Copy link
Member

jakirkham commented Jul 23, 2024

Could we try raising an issue upstream with SciPy and see if there is interest in this feature?

Maybe this is something @joshua-gould could help with 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants